Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8277 lx can use O_DIRECTORY directly #358

Merged
merged 1 commit into from Mar 31, 2021
Merged

OS-8277 lx can use O_DIRECTORY directly #358

merged 1 commit into from Mar 31, 2021

Conversation

papertigers
Copy link

No description provided.

@papertigers papertigers requested a review from danmcd March 31, 2021 16:00
danmcd
danmcd reviewed Mar 31, 2021
View reviewed changes
Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright bump needed?

Also please document testing in bug report.

@papertigers
Copy link
Author

Firing up a test instance now and will dump notes in the ticket.
Copyright is missing here because @citrus-it commited these changes as one chunk. I broke them a part when I created the internal tickets. Would you rather they go back together in #359 and we just drop this PR altogether?

danmcd
danmcd approved these changes Mar 31, 2021
View reviewed changes
Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't sweat copyright. Will IA upon test results.

@danmcd danmcd mentioned this pull request Mar 31, 2021
Merged
@papertigers papertigers merged commit 9d6ec44 into master Mar 31, 2021
@papertigers papertigers deleted the OS-8277 branch March 31, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

Assignees
No one assigned
Labels
integration-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@papertigers @danmcd @citrus-it