Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-8319 lx centos family resolver logic should match ubuntu #376

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

papertigers
Copy link

No description provided.

Copy link
Member

@bahamat bahamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also need to update copyright. make check should complain about that.

usr/src/lib/brand/lx/zone/lx_boot_zone_redhat.ksh Outdated Show resolved Hide resolved
usr/src/lib/brand/lx/zone/lx_boot_zone_redhat.ksh Outdated Show resolved Hide resolved
@danmcd
Copy link

danmcd commented Sep 29, 2021

Needs testing notes on OS-8319 ticket.

Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other question... will this break older Centos? Do we care if it does?

Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about older Centos addressed by Brian on Slack. Don't forget test notes!

@bahamat bahamat self-requested a review September 29, 2021 19:58
@papertigers papertigers merged commit 99707f5 into master Sep 29, 2021
@papertigers papertigers deleted the OS-8319 branch September 29, 2021 20:01
if [ ! -e /etc/resolv.conf ]; then
if [ -h /etc/resolv.conf ]; then
rm -f /etc/resolv.conf
# Populate resolv.conf setup files IFF we have resolvers information.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IFF?

@danmcd
Copy link

danmcd commented Sep 30, 2021

"IFF" == shorthand for "if and only if".

@sjorge
Copy link

sjorge commented Sep 30, 2021

"IFF" == shorthand for "if and only if".

I see, never seen that before! TIL

@danmcd
Copy link

danmcd commented Sep 30, 2021

Yeah, college/uni-level math classes and/or theoretical Computer Science drilled that into my head. It also has formal logic implications: a --> b (If A then B), a <-- b, (A only if B), and a <--> b (A if and only if B, aka A IFF B).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants