-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS-8319 lx centos family resolver logic should match ubuntu #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will also need to update copyright. make check
should complain about that.
Needs testing notes on OS-8319 ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other question... will this break older Centos? Do we care if it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about older Centos addressed by Brian on Slack. Don't forget test notes!
if [ ! -e /etc/resolv.conf ]; then | ||
if [ -h /etc/resolv.conf ]; then | ||
rm -f /etc/resolv.conf | ||
# Populate resolv.conf setup files IFF we have resolvers information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IFF?
"IFF" == shorthand for "if and only if". |
I see, never seen that before! TIL |
Yeah, college/uni-level math classes and/or theoretical Computer Science drilled that into my head. It also has formal logic implications: a --> b (If A then B), a <-- b, (A only if B), and a <--> b (A if and only if B, aka A IFF B). |
No description provided.