Sign encoded URLs #380
Merged
Sign encoded URLs #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcelaya
commented
Nov 23, 2017
| Validate.isTrue(StringUtils.isEmpty(uri.getQuery()), | ||
| "Query must be null or empty. URI: %s", uri); | ||
| } | ||
| Validate.isTrue(StringUtils.isEmpty(uri.getQuery()), |
There was a problem hiding this comment.
StringUtils.isEmpty returns true for null and empty strings
tjcelaya
commented
Nov 23, 2017
| @@ -53,7 +56,7 @@ public void beforeClass() throws IOException { | |||
|
|
|||
| mantaClient = new MantaClient(config); | |||
| testPathPrefix = IntegrationTestConfigContext.generateBasePath(config, this.getClass().getSimpleName()); | |||
| mantaClient.putDirectory(testPathPrefix, null); | |||
| mantaClient.putDirectory(testPathPrefix, true); | |||
There was a problem hiding this comment.
This test case can't be run on its own without changing this to recursive putDirectory
|
@tjcelaya Thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #379 and https://trac.cyberduck.io/ticket/10151
We should be using the encoded URL for signing, e.g.:
instead of