OS-8115 Add support for zfs.sync.change-key channel program #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the corresponding illumos-joyent ticket, the LUA interface was changed slightly in anticipation of upstreaming -- specifically a third argument was added to support either 'raw' or 'hex' keys. While you cannot pass a raw binary string to a LUA channel program, the 'raw' support is preserved in case the channel program itself wishes to generate a binary key through some means.
Since kbmd passes key values as hex, we can simplify things a bit and just pass the hex value directly to
zfs.sync.change_key.