Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

test failure on x86 architecture for ip6_pton #1281

Closed
hasufell opened this issue May 12, 2014 · 18 comments
Closed

test failure on x86 architecture for ip6_pton #1281

hasufell opened this issue May 12, 2014 · 18 comments

Comments

@hasufell
Copy link

I tried both in an x86 virtualbox and compiled with "-m32" on an amd64 host:
https://gist.github.com/hasufell/0f50726e556d842104ab

Doesn't happen on amd64 architecture for me.

@saghul
Copy link
Contributor

saghul commented May 12, 2014

Does it fail on the same machine without specifying "-m 32"?

@hasufell
Copy link
Author

Does it fail on the same machine without specifying "-m 32"?

Nope.

@mtorromeo
Copy link

Same here, I'm holding off updating the archlinux package I am maintaining due to this test failing on x86.

@saghul
Copy link
Contributor

saghul commented May 19, 2014

@mtorromeo are you also compiling with -m 32 or is it a 32bit machine?

@mtorromeo
Copy link

I'm compiling for i686-pc-linux-gnu inside a clean 32bit chroot from a x86_64 host system.

@saghul
Copy link
Contributor

saghul commented May 22, 2014

Can you folks try #1295 ? I could reproduce it and this patch fixed it.

@mtorromeo
Copy link

@saghul nope, still failing like before

`ip6_pton` failed: exit code 134
Output from process `ip6_pton`:
Assertion failed in test/test-ip6-addr.c on line 133: 0 == uv_inet_pton(AF_INET6, "fe80:0:0:0:2acf:daff:1.2.3.4" "%en1", &addr)

@saghul
Copy link
Contributor

saghul commented May 22, 2014

Doh. I'm unable to reproduce the failure. This used to fail on OSX, and this patch fixes it (or so it seems!), used to fail on 32 bit Linux, but doesn't happen either (for me) :-/

Can you please tell me how to reproduce this step by step? Thanks!

@mtorromeo
Copy link

This is the PKGBUILD for archlinux which contains the automated step-by-step instructions: https://gist.github.com/mtorromeo/a2269b0bec1a63034cff

You can try it yourself if you have an archlinux environment at your disposal

Either way its pretty self-explanatory:

  • files in the source=() array are downloaded and extracted
  • the functions are executed in the following order:
    • prepare()
    • build()
    • check()
    • package()

The check() step fails as reported, only on i686.

@saghul
Copy link
Contributor

saghul commented May 22, 2014

I couldn't reproduce it myself, but the jenkins bildbots could. I force pushed the PR, can you please take the patch and test again? Thanks!

@mtorromeo
Copy link

It failed again

@saghul
Copy link
Contributor

saghul commented May 22, 2014

Thanks for testing @mtorromeo. Unfortunately I'm out of ideas. I cannot reproduce it myself, and while the Jenkins machines apparently could, the last version of the patch makes tests pass again :-/

@hasufell
Copy link
Author

The patch from #1295 doesn't work for me either.

@saghul
Copy link
Contributor

saghul commented May 22, 2014

@hasufell how did you compile libuv?

@mtorromeo
Copy link

Maybe gcc 4.9 has something to do with it?

$> gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /build/gcc/src/gcc-4.9-20140507/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-cloog-backend=isl --disable-cloog-version-check --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --disable-multilib --disable-werror --enable-checking=release
Thread model: posix
gcc version 4.9.0 20140507 (prerelease) (GCC)

@hasufell
Copy link
Author

Nope, it is about optimization level, I am checking which one.

@hasufell
Copy link
Author

All of them are affected for me (Os, O1, O2, O3).

@saghul
Copy link
Contributor

saghul commented May 25, 2014

Fixes on #1295 landed on master. Thanks a lot for the help guys!

@saghul saghul closed this as completed May 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants