MANTA-2781 mackerel: deliver-access does not handle backpressure properly

[joyent-automation]

MANTA-2781 mackerel: deliver-access does not handle backpressure properly

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/1599/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@jclulow commented at 2017-03-01T22:55:46

Topic set to MANTA-2781

@davepacheco commented at 2017-03-10T21:32:25

Patch Set 2: Code-Review+1

(4 comments)

@jclulow commented at 2017-03-16T19:12:51

Patch Set 2:

(4 comments)

Patch Set 2 code comments

assets/lib/deliver-access.js#1 @davepacheco

D: (not related to this change)

assets/lib/deliver-access.js#1 @jclulow

Sad face indeed.

assets/lib/deliver-access.js#207 @davepacheco

It'd be nice to have a comment about the input objects and output objects for this stream and what it does.

assets/lib/deliver-access.js#207 @jclulow

Done

assets/lib/deliver-access.js#318 @davepacheco

Could use a vasync barrier here.

assets/lib/deliver-access.js#318 @jclulow

That's true, but I think I'll punt on it for now. If we keep this code as part of Metering v2, I'll address it then.

package.json#16 @davepacheco

I'd suggest eliding the "^".

package.json#16 @jclulow

Done

@davepacheco commented at 2017-03-16T20:38:21

Patch Set 3: Code-Review+1