Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRITON-2274 update moray base image to triton-origin-x86_64-21.4.0 #26

Merged
merged 1 commit into from Mar 29, 2022
Merged

TRITON-2274 update moray base image to triton-origin-x86_64-21.4.0 #26

merged 1 commit into from Mar 29, 2022

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Mar 28, 2022

No description provided.

@bahamat bahamat requested a review from danmcd March 28, 2022 23:41
danmcd
danmcd reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On some of your changes you've lowered the version of "restify", IIRC. Why didn't you do that here? Or is there some subtlety I'm missing?

@bahamat
Copy link
Member Author

bahamat commented Mar 29, 2022

No, I’ve been leaving the testify version the same. Do you have a reference I can check?

danmcd
danmcd approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it out (change from eng), and it's not relevant.

@bahamat bahamat merged commit a202f4a into master Mar 29, 2022
@bahamat bahamat deleted the TRITON-2274 branch March 29, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bahamat @danmcd