Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assert-plus to version 1 (and make tests pass on node v7.6) #63

Closed
wants to merge 2 commits into from

Conversation

jharris4
Copy link
Contributor

@jharris4 jharris4 commented Mar 1, 2017

No description provided.

@arekinath
Copy link
Contributor

So it looks like the major bump in assert-plus was due to assert.number() now accepting Infinity. I've changed our one usage of it (as assert.optionalNumber()) to asssert.optionalFinite() to deal with this and included that in the version of your change that I've merged as 011fa33.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants