net: honor 'enable' flag in .setNoDelay()

Fixes #3096.
nodejs · Apr 12, 2012 · 16fca26 · 16fca26
1 parent 5b43c63
commit 16fca26
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -183,9 +183,10 @@ Socket.prototype._onTimeout = function() {
 };
 
 
-Socket.prototype.setNoDelay = function() {
+Socket.prototype.setNoDelay = function(enable) {
+  // backwards compatibility: assume true when `enable` is omitted
   if (this._handle && this._handle.setNoDelay)
-    this._handle.setNoDelay();
+    this._handle.setNoDelay(typeof enable === 'undefined' ? true : !!enable);
 };
 
 

diff --git a/src/tcp_wrap.cc b/src/tcp_wrap.cc
@@ -253,7 +253,8 @@ Handle<Value> TCPWrap::SetNoDelay(const Arguments& args) {
 
   UNWRAP
 
-  int r = uv_tcp_nodelay(&wrap->handle_, 1);
+  int enable = static_cast<int>(args[0]->BooleanValue());
+  int r = uv_tcp_nodelay(&wrap->handle_, enable);
   if (r)
     SetErrno(uv_last_error(uv_default_loop()));