This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix bug #892. #1226
Closed
Fix bug #892. #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piping a stream to an HTTPS ClientRequest would stall if the request's write() method returned false; the readable stream would pause and never resume because the the request would never emit a drain event. It turns out that the request stream did not listen to the underlying TLS socket drain event because it was expecting the socket to invoke its "ondrain" method instead. Now it does.
|
Has anyone looked at this? It's a pretty serious bug for anyone uploading streams over TLS, although I guess I wouldn't be surprised if I'm the only one doing that. |
|
Hm - do you have a way to reproduce this? |
|
@csosborn: Yep, this looks real. Could you rework your gist above into a test case as part of the pull request? Then we'd prevent this from regression in the future. |
It turns out there was already a regression test for GH 892, but it covers a slightly different (and apparently fixed) aspect of the bug. This new test covers the case where an https client request is piped data directly from a readable stream.
|
The test is not failing on master |
|
Interesting. What platform are you using? I just cloned fresh copies of master onto OS X 10.6.8 and Debian Squeeze machines, and it's failing on both. |
|
@pquerna: is the test failing for you? |
|
Probably, this has fixed in v0.5.8 (#1775), closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piping a stream to an HTTPS ClientRequest would stall if the request's
write() method returned false; the readable stream would pause and
never resume because the the request would never emit a drain event.
It turns out that the request stream did not listen to the underlying
TLS socket drain event because it was expecting the socket to invoke
its "ondrain" method instead. Now it does.