Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

test-child-process-ipc broken on unix #1655

Closed
ry opened this issue Sep 5, 2011 · 3 comments
Closed

test-child-process-ipc broken on unix #1655

ry opened this issue Sep 5, 2011 · 3 comments
Assignees
Labels
Milestone

Comments

@ry
Copy link

ry commented Sep 5, 2011

No description provided.

@bnoordhuis
Copy link
Member

Test breaks because it opens stdin with the old net.Stream(fd) interface.

@ghost ghost assigned bnoordhuis Sep 8, 2011
@bnoordhuis
Copy link
Member

We need proper stdio support in libuv to fix this. I came up with two hacks but we should fix this properly.

743ccb7 - proxies net.Stream(fd) to the proper stdio stream. There's a chicken and egg problem, process.stdin and process.stdout are created with net.Stream(fd) if stdin/stdout isn't a tty. You can side-step it (I did) but it's not pretty.

2fcab85 - use an IOWatcher from net_legacy.js as a stop-gap measure.

@ry
Copy link
Author

ry commented Sep 26, 2011

this test is working in 02e0a0a

@ry ry closed this as completed Sep 26, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants