vcbuild: node_use_isolates is not defined

[llafuente]

Hi,

I didnt pull a request because I dont know what is the purpose of this var.

Last version (master) dont compile because this var is not defined, quick fix is to add

'node_use_isolates' : 'false',

to "node.gyp"@"variables"

Here is the report for google reasons :)

Traceback (most recent call last):

File "tools\gyp_node", line 59, in

run_gyp(gyp_args)

File "tools\gyp_node", line 18, in run_gyp

rc = gyp.main(args)

File ".\tools\gyp\pylib\gyp__init__.py", line 471, in main

options.circular_check)

File ".\tools\gyp\pylib\gyp__init__.py", line 111, in Load

depth, generator_input_info, check, circular_check)

File ".\tools\gyp\pylib\gyp\input.py", line 2270, in Load

depth, check)

File ".\tools\gyp\pylib\gyp\input.py", line 387, in LoadTargetBuildFile

build_file_path)

File ".\tools\gyp\pylib\gyp\input.py", line 1010, in ProcessVariablesAndConditionsInDict

build_file)

File ".\tools\gyp\pylib\gyp\input.py", line 1025, in ProcessVariablesAndConditionsInList

ProcessVariablesAndConditionsInDict(item, is_late, variables, build_file)

File ".\tools\gyp\pylib\gyp\input.py", line 984, in ProcessVariablesAndConditionsInDict

ProcessConditionsInDict(the_dict, is_late, variables, build_file)

File ".\tools\gyp\pylib\gyp\input.py", line 842, in ProcessConditionsInDict

if eval(ast_code, {'builtins': None}, variables):

File "", line 1, in
NameError: name 'node_use_isolates' is not defined while evaluating condition 'node_use_isolates=="true"' in node.gyp while trying to load node.gyp

Failed to create vc project files.

[bnoordhuis]

You need to run the configure script again (possibly with --without-isolates). Note that isolates support is still very experimental and certified broken on Windows.

[bradw2k]

vcbuild.bat is broken, re-running does not fix, cannot compile 0.6.6 on Windows.

[llafuente]

in fact is broken.

"vcbuild --without-isolates"
dont do anything at all. because this argument is forced in configure an not define "node_use_isolates" at node.gyp execution

btw: there is another error related to "isotales" after editing node.gyp and add 'node_use_isolates' : 'false', you get:

src\node_isolate.cc(78): error C2275: 'node::Isolate' : illegal use of this type as an expression [C:\noboxout\nodejs\radamn\deps\node\node.vcxproj]
src\node_isolate.cc(78): error C2597: illegal reference to non-static member 'node::Isolate::list_member_' [C:\noboxout\nodejs\radamn\deps\node\node.vcxproj]
src\node_isolate.cc(78): error C3861: 'offsetof': identifier not found [C:\noboxout\nodejs\radamn\deps\node\node.vcxproj]

That wasn't a problem for me because node.lib was created but node.exe didnt.
I compile against node.lib and run with the oficial 6.6 package and works.

if you remove src/node_isolate.h and src/node_isolate.cc from node you have plenty of link errors... so dont help either...

[bnoordhuis]

@bradw2k: It must be something unrelated because isolates support exists only in the 0.7 / master branch.

@llafuente: python configure --without-isolates, then vcbuild

[llafuente]

I see the merge in the master
0c3b357

And configure also crash :S

C:\noboxout\nodejs\radamn\deps\node>python --version
Python 2.7.2

C:\noboxout\nodejs\radamn\deps\node>python configure --without-isolates
{ 'target_defaults': { 'cflags': [],
'defines': [],
'include_dirs': [],
'libraries': ['-lz']},
'variables': { 'host_arch': 'ia32',
'node_debug': 'false',
'node_install_npm': 'true',
'node_prefix': '',
'node_shared_cares': 'false',
'node_shared_v8': 'false',
'node_use_dtrace': 'false',
'node_use_isolates': 'false',
'node_use_openssl': 'true',
'node_use_system_openssl': 'false',
'target_arch': 'ia32',
'v8_use_snapshot': 'true'}}
creating config.gypi
Traceback (most recent call last):
File "configure", line 273, in
subprocess.call(['tools/gyp_node','-f', 'make'])
File "C:\Python27\lib\subprocess.py", line 493, in call
return Popen(_popenargs, *_kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 679, in init
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 893, in _execute_child
startupinfo)
WindowsError: [Error 2] El sistema no puede hallar el archivo especificado

[bnoordhuis]

Don't let that bother you. The important part is that a config.gypi was created, vcbuild.bat will take care of the rest.

[bradw2k]

bnoordhuis: On two Win7 machines with Python 2.7.2 I get exactly the same stack trace as reported in the first message by llafuente:

File "", line 1, in
NameError: name 'node_use_isolates' is not defined while evaluating condition 'node_use_isolates=="true"' in node.gyp while trying to load node.gyp

I don't know anything about Python or GYP so I stopped there, and switched to 0.6.2, which builds fine for me.

[gero3]

When I try this, I get this as error

Project files generated.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppBuild.targets(1151,5): warning MSB8012: TargetPath(C:\Users\Jeroen\Downloads\cloud9\node\Debug\http_parser.lib) does not match the Library's OutputFile property value (C:\Users\Jeroen\Downloads\cloud9\node\Debug\lib\http_parser.lib). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\Users\Jeroen\Downloads\cloud9\node\deps\http_parser\http_parser.vcxproj]
  http_parser.vcxproj -> C:\Users\Jeroen\Downloads\cloud9\node\Debug\http_parser.lib
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppBuild.targets(1151,5): warning MSB8012: TargetPath(C:\Users\Jeroen\Downloads\cloud9\node\Debug\v8_base.lib) does not match the Library's OutputFile property value (C:\Users\Jeroen\Downloads\cloud9\node\Debug\lib\v8_base.lib). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\Users\Jeroen\Downloads\cloud9\node\deps\v8\tools\gyp\v8_base.vcxproj]
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppBuild.targets(1151,5): warning MSB8012: TargetPath(C:\Users\Jeroen\Downloads\cloud9\node\Debug\zlib.lib) does not match the Library's OutputFile property value (C:\Users\Jeroen\Downloads\cloud9\node\Debug\lib\zlib.lib). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\Users\Jeroen\Downloads\cloud9\node\deps\zlib\zlib.vcxproj]
  zlib.vcxproj -> C:\Users\Jeroen\Downloads\cloud9\node\Debug\zlib.lib
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppBuild.targets(1151,5): warning MSB8012: TargetPath(C:\Users\Jeroen\Downloads\cloud9\node\Debug\uv.lib) does not match the Library's OutputFile property value (C:\Users\Jeroen\Downloads\cloud9\node\Debug\lib\uv.lib). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\Users\Jeroen\Downloads\cloud9\node\deps\uv\uv.vcxproj]
  uv.vcxproj -> C:\Users\Jeroen\Downloads\cloud9\node\Debug\uv.lib
  v8_base.vcxproj -> C:\Users\Jeroen\Downloads\cloud9\node\Debug\v8_base.lib
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppBuild.targets(1151,5): warning MSB8012: TargetPath(C:\Users\Jeroen\Downloads\cloud9\node\Debug\openssl.lib) does not match the Library's OutputFile property value (C:\Users\Jeroen\Downloads\cloud9\node\Debug\lib\openssl.lib). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\Users\Jeroen\Downloads\cloud9\node\deps\openssl\openssl.vcxproj]
  openssl.vcxproj -> C:\Users\Jeroen\Downloads\cloud9\node\Debug\openssl.lib
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppBuild.targets(1151,5): warning MSB8012: TargetPath(C:\Users\Jeroen\Downloads\cloud9\node\Debug\v8_nosnapshot.lib) does not match the Library's OutputFile property value (C:\Users\Jeroen\Downloads\cloud9\node\Debug\lib\v8_nosnapshot.lib). This may cause your project to build incorrectly. To correct this, please make sure that $(OutDir), $(TargetName) and $(TargetExt) property values match the value specified in %(Lib.OutputFile). [C:\Users\Jeroen\Downloads\cloud9\node\deps\v8\tools\gyp\v8_nosnapshot.vcxproj]
  v8_nosnapshot.vcxproj -> C:\Users\Jeroen\Downloads\cloud9\node\Debug\v8_nosnapshot.lib
LINK : fatal error LNK1104: cannot open file 'z.obj' [C:\Users\Jeroen\Downloads\cloud9\node\deps\v8\tools\gyp\mksnapshot.vcxproj]

[bnoordhuis]

@gero3: That's unrelated.

[gero3]

but I had it after I used

python configure --without-isolates, then vcbuild

[chowey]

For the record, @bnoordhuis solution worked for me.

[chowey]

Well, until I got the following fatal error in the build sequence:

LINK : fatal error LNK1104: cannot open file 'z.obj' [c:\node\deps\v8\tools\gyp\mksnapshot.vcxproj]