Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

repl: strict mode SyntaxErrors not shown #5178

Closed
bnoordhuis opened this issue Mar 30, 2013 · 3 comments
Closed

repl: strict mode SyntaxErrors not shown #5178

bnoordhuis opened this issue Mar 30, 2013 · 3 comments
Labels

Comments

@bnoordhuis
Copy link
Member

$ out/Release/node
> (function() { return 0755; })()
493
> (function() { "use strict"; return 0755; })()
...

Expected behavior: "Octal literals are not allowed in strict mode" SyntaxError is thrown.

Actual behavior: The REPL waits for more input.

Low priority issue.

@TooTallNate
Copy link

@bnoordhuis Want to review TooTallNate/node@085f9d636b260724af2e80d6757e9d0f4bcd9193?

@bnoordhuis
Copy link
Member Author

LGTM, nice work. There is a long line in the test but if you're not bothered by it, then I'm not either.

@TooTallNate
Copy link

The long line in the test doesn't bother me. Landed in v0.10 branch in 085f9d6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants