Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

nodejs debug doesn't show current line without color support #6150

Closed
LegalizeAdulthood opened this issue Aug 29, 2013 · 4 comments
Closed
Labels

Comments

@LegalizeAdulthood
Copy link

Suppose I ssh into a box and run nodejs debugger on a script... if my ssh client doesn't support coloring, then I have no idea where the debugger is executing because it gives no indication of current location other than coloring.

@LegalizeAdulthood
Copy link
Author

ok, it does provide a line number:

debug> n
debug> debug> break in ci-dashboard.js:5
  3 var proc = require('child_process');
  4 var async = require('async');
  5 var moment = require('moment');
  6 
  7 var user_names = {

So it does tell me that I'm on line 5. It would be preferred if line 5 were annotated in some fashion other than color, however. something like:

debug> n
debug> debug> break in ci-dashboard.js:5
  3 var proc = require('child_process');
  4 var async = require('async');
> 5 var moment = require('moment');
  6 
  7 var user_names = {

@isaacs
Copy link

isaacs commented Aug 29, 2013

Sure, I'd be ok with a > on that line as well as the color change, but it's not super high priority. Patch welcome.

@rlidwka
Copy link

rlidwka commented Sep 28, 2013

Debugger is always printing out 5 lines with active line in the middle, right? So it isn't really that bad.

An issue with printing > before line is that most files have hundreds of lines, so there is no free space for it.

edit: nevermind, I see now how breakpoints are shown. I'll look into it.

@bnoordhuis
Copy link
Member

Fixed by 028e652.

tjfontaine added a commit that referenced this issue Oct 30, 2013
* uv: Upgrade to v0.11.14

* v8: upgrade 3.21.18.3

* assert: indicate if exception message is generated (Glen Mailer)

* buffer: add buf.toArrayBuffer() API (Trevor Norris)

* cluster: fix premature 'disconnect' event (Ben Noordhuis)

* crypto: add SPKAC support (Jason Gerfen)

* debugger: count space for line numbers correctly (Alex Kocharin)

* debugger: make busy loops SIGUSR1-interruptible (Ben Noordhuis)

* debugger: repeat last command (Alex Kocharin)

* debugger: show current line, fix for #6150 (Alex Kocharin)

* dgram: send() can accept strings (Trevor Norris)

* dns: rename domain to hostname (Ben Noordhuis)

* dns: set hostname property on error object (Ben Noordhuis)

* dtrace, mdb_v8: support more string, frame types (Dave Pacheco)

* http: add statusMessage (Patrik Stutz)

* http: expose supported methods (Ben Noordhuis)

* http: provide backpressure for pipeline flood (isaacs)

* process: Add exitCode property (isaacs)

* tls: socket.renegotiate(options, callback) (Fedor Indutny)

* util: format as Error if instanceof Error (Rod Vagg)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants