node.gyp change breaks build when using system v8 library

[CraZySacX]

This change in node.gyp

[
'OS=="linux"', {
'ldflags': [
'-Wl,--whole-archive <(PRODUCT_DIR)/obj.target/deps/v8/tools/gyp/libv8_base.a -Wl,--no-whole-archive',
],
}],

breaks the build when using --shared-v8, --shared-v8-includes and --shared-v8-libs as the libv8_base.a file doesn't exist.

[tjfontaine]

Sorry about that, I will fix that this morning

[tjfontaine]

@CraZySacX can you try

diff --git a/node.gyp b/node.gyp
index a0a1774..f8f4a9a 100644
--- a/node.gyp
+++ b/node.gyp
@@ -320,7 +320,7 @@
           ],
         }],
         [
-          'OS=="linux"', {
+          'OS=="linux" and node_shared_v8=="false"', {
             'ldflags': [
               '-Wl,--whole-archive <(PRODUCT_DIR)/obj.target/deps/v8/tools/gyp/libv8_base.<(target_arch).a -Wl,--no-whole-archive',
             ],

[CraZySacX]

That fix works.

[tjfontaine]

thanks fixed in 92bbd60