You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
@tjfontaine if you want to implement this on 0.10, this commit should probably be included. Are you OK with that? Also, what do you mean by "then fix the v0.12 issue"?
You also mentioned that 65536 * 2 is an arbitrary value. Did you want this to be a parameter?
@orangemocha it wasn't documented, but works sometimes in v0.10, so ideally we would resolve that inconsistency, but I am fine with delaying that all as a feature for v0.12
@cjihrig I'm not sure I want to bring that commit down to v0.10 would need to talk more about it.
In v0.10
child_process
target.send
sometimes returns if thewriteQueueSize
is smaller than some "arbitrary" value https://github.com/joyent/node/blob/v0.10/lib/child_process.js#L481 but not all code paths do this.In v0.12 we don't even bother trying to report the value https://github.com/joyent/node/blob/v0.12/lib/child_process.js#L415
We should make the code paths consistent for v0.10, merge the branch into v0.12, and then fix the v0.12 issue.
The text was updated successfully, but these errors were encountered: