Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Consistency between http.getAgent and https.getAgent #943

Closed
indexzero opened this issue Apr 17, 2011 · 1 comment
Closed

Consistency between http.getAgent and https.getAgent #943

indexzero opened this issue Apr 17, 2011 · 1 comment

Comments

@indexzero
Copy link

Working on adding HTTPS support to node-http-proxy and I've come across an inconsistency in the https vs. http APIs. The correct usage for "getAgent" on the respective modules are:

https.getAgent({
  host: 'localhost',
  port: 8080
});

http.getAgent('localhost', 8080);

Wanted to get input before I whip up a patch one way or the other.

@indexzero
Copy link
Author

Thanks! See: http-party/node-http-proxy#48 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant