This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Support for Visual Studio 2015 #25857
Closed
+3,505
−2,595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is happy. LGTM |
Gyp update to be able to generate VS2015 projects.
This is a port of nodejs/node@eb459c8 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: nodejs/node#1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: #3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390
This is a port of nodejs/node@4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
added a commit
that referenced
this pull request
Aug 24, 2015
Gyp update to be able to generate VS2015 projects. PR-URL: #25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
shigeki
pushed a commit
that referenced
this pull request
Aug 24, 2015
This is a port of nodejs/node@eb459c8 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: nodejs/node#1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
pushed a commit
that referenced
this pull request
Aug 24, 2015
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: #3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 PR-URL: #25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
pushed a commit
that referenced
this pull request
Aug 24, 2015
This is a port of nodejs/node@4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: #25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
added a commit
to JaneaSystems/node
that referenced
this pull request
Sep 12, 2015
This is a port of a525c72 . Original commit message: Gyp update to be able to generate VS2015 projects. PR-URL: nodejs/node-v0.x-archive#25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
pushed a commit
to JaneaSystems/node
that referenced
this pull request
Sep 12, 2015
This is a port of eb459c8 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: nodejs#1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> This was ported to v0.10 in nodejs/node-v0.x-archive#25857
joaocgreis
pushed a commit
to JaneaSystems/node
that referenced
this pull request
Sep 12, 2015
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: nodejs#3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 This was ported to v0.10 in nodejs/node-v0.x-archive#25857
joaocgreis
pushed a commit
to JaneaSystems/node
that referenced
this pull request
Sep 12, 2015
This is a port of 4208dc4 . Original commit message: PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs/node-v0.x-archive#25857
joaocgreis
added a commit
to nodejs/node
that referenced
this pull request
Sep 16, 2015
This is a port of a525c72 . Original commit message: Gyp update to be able to generate VS2015 projects. PR-URL: nodejs/node-v0.x-archive#25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
shigeki
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 16, 2015
This is a port of eb459c8 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: #1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> This was ported to v0.10 in nodejs/node-v0.x-archive#25857 PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
joaocgreis
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 16, 2015
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: #3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 This was ported to v0.10 in nodejs/node-v0.x-archive#25857 PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
rvagg
added a commit
to nodejs/node
that referenced
this pull request
Sep 16, 2015
This is a port of 4208dc4 . Original commit message: PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs/node-v0.x-archive#25857 PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
This is a port of a525c72 . Original commit message: Gyp update to be able to generate VS2015 projects. PR-URL: nodejs#25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: nodejs/node#2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
This is a port of eb459c8 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: nodejs/node#1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> This was ported to v0.10 in nodejs#25857 PR-URL: nodejs/node#2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: nodejs#3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 This was ported to v0.10 in nodejs#25857 PR-URL: nodejs/node#2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
This is a port of 4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs#25857 PR-URL: nodejs/node#2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Visual Studio 2015 is added in 3 steps:
docs/,README.mdandtest/were removed from the tree, and a floating patch to work on MacOSX without XCode was added in its own commit. The files undertools/gyp/are exactly the same as the ones in nodejs/node.vcbuild.bat.Note that to port this into v0.12, the commits discussed in #25569 are also needed and #25804 should land before.
cc @joyent/node-collaborators