This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
http: fix http-parser is freed twice #2704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after response to CONNECT/Upgrade request.
|
One (trivial!) nit, otherwise LGTM. Where/when did you find out about this? |
|
@bnoordhuis - Thanks! merging. |
|
@bnoordhuis - Because node-tunnel works with v0.7.0, but fails with v0.7.1 and v0.7.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http-parser is freed twice after response to CONNECT/Upgrade request.
This should be fixed after 35fe3eb (v0.6) was merged. But I did not notice it... Sorry, my mistake.
Please review.