This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
expose ares_get_servers in cares_wrap #3132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cur = cur->next; | ||
| } | ||
|
|
||
| callback->Call(Context::GetCurrent()->Global(), 1, argv); |
There was a problem hiding this comment.
If it's a synchronous function, you don't have to make a callback, just return the result. Callbacks are supposed to run on the next tick of the event loop anyway.
There was a problem hiding this comment.
Right, but if/when the pure js dns implementation happens, then ares would only be initialized (on the thread pool) when needing to get this information and then disposed. So I designed it this way so I could use it in the module now and not change the consuming code if/when #3018 is merged.
There was a problem hiding this comment.
Okay, fair enough. Can you add a JS shim that defers the callback to the next tick?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes ares_get_servers as cares_wrap.getServers which passes to a callback an array of IPs that ares is currently using for resolution.
It's callback based with an eye towards #3018 where ares would be initialized on the thread pool during platform initialization only to retrieve relevant platform information and then be immediately disposed.