This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix #3425: removeAllListeners should delete array #3431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removeAllListeners is called, the listeners array is deleted to maintain compatibility with v0.6. Reverts "events: don't delete the listeners array" This reverts commit 78dc13f. Conflicts: test/simple/test-event-emitter-remove-all-listeners.js
|
See #3425 (comment) for my alternate proposal for a solution. |
|
@isaacs This needs an API doc clarification, but I haven't yet come up with something that doesn't refer to EventEmitter's internals. |
| this._events[type] = null; | ||
| } | ||
|
|
||
| // does not use listeners(), so no side effect of creating _events[type] |
There was a problem hiding this comment.
@TooTallNate The reverted behavior explicitly tries to avoid calling listeners() to avoid creating _events[type]. Is that still needed?. Regarding your proposal in #3425 (comment)
There was a problem hiding this comment.
I personally think that's overkill. I don't consider removeAllListeners() to be a hot code path enough to justify that, but others would need to weigh in on that as well.
|
Landed, along with an alternate fix for the thing that this was fixing, and clarification in the docs. Thanks, everyone :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removeAllListeners is called, the listeners array is deleted to maintain compatibility with v0.6.
This request fixes issue #3425 by reverting 78dc13f. In addition to the revert, I've updated the tests to match the reverted behavior.