Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

handle multiple values of 'proxy-authenticate' #4052

Closed
wants to merge 1 commit into from

2 participants

@thewilli

Just as the 'WWW-Authenticate' HTTP header the 'Proxy-Authenticate' header might be received several times as well. Currently only one values is preserved. This change allows to receive multiple values concatenated by space and comma.

@thewilli thewilli handle multiple values of 'proxy-authenticate'
Just as the 'WWW-Authenticate' HTTP header the 'Proxy-Authenticate' header might be received several times as well. Currently only one values is preserved. This change allows to receive multiple values concatenated by space and comma.
81ae3f0
@bnoordhuis

Thanks. Can you sign the CLA?

@bnoordhuis

Oh, a regression test in test/simple/test-http-server-multiheaders.js would be nice, too.

@thewilli

I just signed the CLA online and added the test (see here).

@bnoordhuis

Thanks Willi, landed in ac17dc1.

@bnoordhuis bnoordhuis closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 24, 2012
  1. @thewilli

    handle multiple values of 'proxy-authenticate'

    thewilli authored
    Just as the 'WWW-Authenticate' HTTP header the 'Proxy-Authenticate' header might be received several times as well. Currently only one values is preserved. This change allows to receive multiple values concatenated by space and comma.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  lib/http.js
View
1  lib/http.js
@@ -401,6 +401,7 @@ IncomingMessage.prototype._addHeaderLine = function(field, value) {
case 'pragma':
case 'link':
case 'www-authenticate':
+ case 'proxy-authenticate':
case 'sec-websocket-extensions':
case 'sec-websocket-protocol':
if (field in dest) {
Something went wrong with that request. Please try again.