This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
http: fix http.ClientRequest#write callback
#5730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix how? The commit log should go into more detail on what is broken and how it's addressed. |
| var callbackCalled = false; | ||
| var finishCalled = false; | ||
|
|
||
| var server = http.createServer(function (req, res) { |
If you pass in a callback as third argument to the `write` or the `end` function on `http.ClientRequest`, it is ignored today. In some cases, when the callback is passed as the second argument, it may not call it. Fixes nodejs#5729
|
@bnoordhuis Fixed the comments and also extended the test case to catch a bug when the callback was not called when it was passed as the second argument. I'll hope the commit message is descriptive enough now. |
|
Do you need anything more from me? |
|
Is this patch satisfactory, or is something else needed? |
|
Did this somewhat differently on da93d6a. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes
http.ClientRequest#end.fixes #5729