This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
test: fix test-cluster-disconnect #6840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was not waiting for all the worker-created sockets to be listening before calling cluster.disconnect(). As a result, the channels with the workers could get closed before all the socket handles had been passed to them, leading to various errors.
When a child process closes the channel to the parent, we should call _disconnect(), which raises the 'disconnect' event immediately, rather than disconnect(), which can potentially be deferred if there is a handle queue on the channel. A deferred disconnect would never be processed because the other side is gone and the channel will never be drained.
|
I'm going to land the first commit, can we get a test for the second commit? |
|
first part is landed in dc1ffd0 |
|
The test failure has been fixed and there is no evidence that the issue addressed by 7d0e06c can actually occur. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes the test.
The second commit is not absolutely critical, however I discovered thanks to the broken test that when a channel is closed that has a handle queue on it, the disconnect event will never fire.