This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
doc: fix Folders as Modules omission of index.json #8868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section was inconsistent with the actual behavior of `require` and with other parts of this same document, which do describe the ability to treat index.json as a module’s default file.
|
Potentially, this could be even further clarified regarding directories that contain a |
|
I'm rather surprised this was never looked at. I notice the doc problem still exists in v0.12 and nodejs/node master too. LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 29, 2015
This section was inconsistent with the actual behavior of `require` and with other parts of this same document, which do describe the ability to treat index.json as a module’s default file. PR-URL: #8868 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
|
Landed in 62c8948 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section was inconsistent with the actual behavior of
requireandwith other parts of this same document, which do describe the ability
to treat index.json as a module’s default file.
PR inspired by the discussion at michaelficarra/us-states#3