initial work on sdc-vmapi for PUBAPI-1420 #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterdjules
force-pushed
the
tritonnfs
branch
from
836aaa5
to
5041283
Compare
joshwilsdon
force-pushed
the
PUBAPI-1420
branch
from
045bd4c
to
20aaf05
Compare
lib/workflows/provision.js
Outdated
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| var async = require('async'); | |||
| var childProcess = require('child_process'); | |||
| var jsprim = require('jsprim'); | |||
There was a problem hiding this comment.
Is jsprim available to be required as a module from a workflow job?
| } | ||
|
|
||
| if (job.params.docker === true) { | ||
| // We create a separate copy of the metadata for docker:nfsvolumes, |
misterdjules
approved these changes
Sep 20, 2017
|
integrated via 4831338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for sdc:volumes for non-Docker