OS-8136 Add DISCARD/TRIM support to bhyve #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerdts
previously approved these changes
Mar 20, 2020
papertigers
previously approved these changes
Mar 20, 2020
sjorge
previously approved these changes
Mar 20, 2020
jasonbking
dismissed stale reviews from sjorge, papertigers, and mgerdts
via
c9950c9
added 2 commits
March 20, 2020 22:29
mgerdts
approved these changes
Mar 22, 2020
papertigers
approved these changes
Mar 23, 2020
|
I gave you the IA label but apparently it's not used for this repo. This lgtm, feel free to integrate. The testing notes in the ticket look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smarts-live portions necessary for the change.