Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8250 Create 16gb.img in smartos-live #965

Merged
merged 1 commit into from Dec 2, 2020
Merged

OS-8250 Create 16gb.img in smartos-live #965

merged 1 commit into from Dec 2, 2020

Conversation

danmcd
Copy link
Contributor

@danmcd danmcd commented Dec 1, 2020

Subject says it all.

@danmcd danmcd requested a review from kusor December 1, 2020 20:17
@danmcd danmcd self-assigned this Dec 1, 2020
@danmcd
Copy link
Contributor Author

danmcd commented Dec 1, 2020 •
edited

NOTE: This is Pedro's work, I'm pushing it along (no pun intended).
So he's "reviewed" it, but I'm actually going to be the reviewer in the commit message.

kusor
kusor approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@kusor kusor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danmcd!

I really dunno why we don't build these images with sdc-headnode. I'll make a note there regarding where to go when adding a new image size is required due to whatever the reason.

@danmcd danmcd merged commit 81fcf4f into master Dec 2, 2020
@danmcd danmcd deleted the OS-8250 branch November 16, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusor kusor kusor approved these changes

@papertigers papertigers papertigers approved these changes

Assignees

@danmcd danmcd

Labels
integration-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danmcd @kusor @papertigers @timfoster @bahamat