Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRITON-2242 zfs.js needs to be reconciled across smartos-live, node-zfs and node-zfs/linuxcn #997

Merged
merged 5 commits into from Aug 17, 2021

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Aug 12, 2021

This includes changes from node-zfs for the following:

  • CNAPI-286
  • AGENT-645
  • AGENT-785
  • TOOLS-607

danmcd
danmcd previously approved these changes Aug 12, 2021
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here seem far less impactful w.r.t. least-surprise.

danmcd
danmcd previously approved these changes Aug 13, 2021
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, please make sure the testing notes go in TRITON-2242.

@bahamat bahamat merged commit 25b8e95 into master Aug 17, 2021
@bahamat bahamat deleted the TRITON-2242 branch August 17, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants