Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRITON-2123 cmon should omit nat zones #20

Merged
merged 1 commit into from
May 1, 2020
Merged

TRITON-2123 cmon should omit nat zones #20

merged 1 commit into from
May 1, 2020

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Apr 30, 2020 •
edited

For reference, CNS doesn't provide names for nat zones, so CMON can't work on them.

TritonDataCenter/triton-cns@dca1dc6

@bahamat bahamat marked this pull request as ready for review May 1, 2020 02:24
@bahamat
Copy link
Member Author

bahamat commented May 1, 2020

Created an image in and installed it in west-a. CMON seems to work properly, and it skipping nat zones as expected.

@bahamat bahamat requested review from isaacdavis and rjloura May 1, 2020 02:24
rjloura
rjloura approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@rjloura rjloura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. It has been a while since I looked at CMON so it is probably a good idea to have someone else take a look as well.

isaacdavis
isaacdavis approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@isaacdavis isaacdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bahamat bahamat merged commit 0775ea3 into TritonDataCenter:master May 1, 2020
@bahamat bahamat deleted the TRITON-2123 branch May 1, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjloura rjloura rjloura approved these changes

@isaacdavis isaacdavis isaacdavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bahamat @rjloura @isaacdavis