Skip to content
This repository has been archived by the owner on Oct 3, 2018. It is now read-only.

Moving towards a 1.0 release #41

Closed
hassankhan opened this issue Aug 15, 2014 · 28 comments
Closed

Moving towards a 1.0 release #41

hassankhan opened this issue Aug 15, 2014 · 28 comments

Comments

@hassankhan
Copy link
Contributor

Just throwing around ideas here for a v1.0 release.

Config options

Relevant issue

Emoji sets

Relevant issue

Task runner

Also, I've started using Gulp and I've got to say it seems a lot nicer to use than Grunt, so maybe switch over to Gulp too. @adam-lynch has volunteered!

Obviously every task should be available as it was before, but I also think Gulp allows some more flexibility, and we can take advantage of that with new tasks. The best example I can think of is porting the update.sh file over.

This might take longer because a Gulp task doesn't seem to be working for me.

What do you guys think? @qq99 @suprememoocow

@qq99
Copy link
Contributor

qq99 commented Aug 17, 2014

I like the sounds of blacklist for specific emoji 👍

@hassankhan hassankhan changed the title Consider cleaning up options Moving towards a 1.0 release Sep 21, 2014
@hassankhan
Copy link
Contributor Author

Use shim for IE8 and co.

Relevant issue

Spritesheets

Relevant issue

@adam-lynch
Copy link
Contributor

I can do the Grunt -> Gulp conversion.

@hassankhan FYI, the links in your second comment there are broken.

@adam-lynch
Copy link
Contributor

Moving to Gulp needs to wait til #47 is merged I guess.

@adam-lynch
Copy link
Contributor

An even better table of emoji: http://emoji.codes/family

@hassankhan
Copy link
Contributor Author

Cleanup project root

Relevant issue

@BenMQ
Copy link
Contributor

BenMQ commented Sep 24, 2014

I'm interested in helping out with the Config options enhancement, I find it useful in my own usage 😃

@hassankhan
Copy link
Contributor Author

Automate version bumping

Relevant issue

@hassankhan
Copy link
Contributor Author

Add emojify.js to a CDN

Relevant issue

@hassankhan
Copy link
Contributor Author

Remove images directory

Now part of this issue

@hassankhan
Copy link
Contributor Author

Support Node environment properly

Relevant issue
Relevant issue

@hassankhan
Copy link
Contributor Author

Add code coverage results

Relevant issue

@adam-lynch
Copy link
Contributor

Grunt -> Gulp done; #85.

@hassankhan would you be open to creating a Trello / waffle.io board for this repo? It would make it easier to complete all these tasks.

@hassankhan
Copy link
Contributor Author

Have you perchance got ZenHub installed on Chrome? I installed it yesterday, has a pretty good board (or at least I thought so)

@adam-lynch
Copy link
Contributor

@hassankhan this looks good. Do you have a project for emojify.js on it? How do I access?

@adam-lynch
Copy link
Contributor

We should make a new release now. We have added some major features; full Node support, sprites, etc. There are no real outstanding or ongoing PRs so it'll be a long time before we get all of these features done for version 1.0.

@hassankhan give me the go ahead and I'll publish to npm 😄 (and of course merge develop into master)

@hassankhan
Copy link
Contributor Author

Yep, I agree. Last thing I wanted to do was integrate the failing test PRs (#62 and #57) and see if those've been fixed. If that's all good, I think it's time to release 1.0!!

@hassankhan
Copy link
Contributor Author

Oh, actually there was one more thing I wanted to do: tidy up config options. I'll try and find some time this weekend to land that, then I'm happy for you to release.

BTW, can you even submit to npm for me? I thought I had to update my npm packages myself 😕

@adam-lynch
Copy link
Contributor

#57 is less important since everything is supported in Node now. It's less likely that someone will pass a HTML string to replace. I created it and I won't be using replace anymore probably. It should be fixed but not urgently.

For tidying up the config options, can you create an issue clearly defining what the config should be?

BTW, can you even submit to npm for me? I thought I had to update my npm packages myself 😕

Yeah. See node-webkit-builder (I'm listed as a maintainer) for example. I think you need to run npm owner add adam-lynch emojify.js, see npm-owner.

@hassankhan
Copy link
Contributor Author

There's an open issue (#87) for the config options. I'll run the npm owner command when I get home later tonight, hopefully 😄 Might also be worth adding npm publish to the gulp release command

@adam-lynch
Copy link
Contributor

How about a version 1.0 now? It's a shame those changes aren't out there.

P.S. Did you add me as an owner to the npm package? 😃

@adam-lynch
Copy link
Contributor

ping

@hassankhan
Copy link
Contributor Author

Hiya, sorry it's been mental at work launching a few campaigns, will probably do the release over the Xmas break

@adam-lynch
Copy link
Contributor

@hassankhan if you add me as an owner to the npm package then I can make the release.

@4ver
Copy link
Contributor

4ver commented Dec 11, 2014

@hassankhan @adam-lynch Ye could make a 0.10.0 release and wait for the api change to release 1.0 ?

@adam-lynch
Copy link
Contributor

😦 Ok, we think we will have to fork this and maintain it ourselves. This project moves far too slowly. It's very frustrating. We added big features as far back as October (which we need) which still aren't released.

We've been trying to work using the develop branch and it's not working out (one related issue: #114). We need versions to be published to npm.

Also, we want Emoji One support so we think we'd have that done and released faster if we maintained our own project.

@hassankhan
Copy link
Contributor Author

I'd prefer a 0.10 release first, before I get some time to redo the options.

@hassankhan
Copy link
Contributor Author

v1.0 is finally out, thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants