Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with non founding members preview list #289

Closed
bedeho opened this issue Mar 18, 2021 · 3 comments
Closed

Issues with non founding members preview list #289

bedeho opened this issue Mar 18, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bedeho
Copy link
Member

bedeho commented Mar 18, 2021

Two questions about this section

Screenshot 2021-03-18 at 18 53 55

  1. Why do the membership avatars not get displayed here? It also not happen on the full ranking by the way.
  2. The link goes to the wrong full ranking, it goes to the founding member overview.
@bedeho bedeho added the bug Something isn't working label Mar 18, 2021
@DzhideX
Copy link
Contributor

DzhideX commented Mar 19, 2021

  1. The data for all of these comes from the founding-members repo under data/fm-info.json. As it currently stands non-fm members don't have any avatars there. I could technically make a request for those avatars from the testnet but that would astronomically shoot-up the loading times for non-fm members. I think the best solution, if we really want their testnet avatars is to somehow manually add them to the json itself? Would that be possible @bwhm?

  2. This has been fixed in the PR i just mentioned!

@bedeho
Copy link
Member Author

bedeho commented Mar 19, 2021

  1. Why not just load the page as you are doing now, but then do async in place loading of individual handles as the next step? The current hundreds of grey circles just make no sense.

@DzhideX
Copy link
Contributor

DzhideX commented Mar 20, 2021

Agreed and it really doesn't make sense to add them manually to the JSON. Will get on it asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants