Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji in Emoji cheat sheet are not rendered #617

Closed
shin-sforzando opened this issue Jul 25, 2023 · 4 comments
Closed

Emoji in Emoji cheat sheet are not rendered #617

shin-sforzando opened this issue Jul 25, 2023 · 4 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@shin-sforzando
Copy link
Contributor

shin-sforzando commented Jul 25, 2023

Issue description

Congo official document describes the Emoji cheat sheet as a useful reference for finding Emoji shortcodes, but the examples used on that page, see_no_evil 🙈, hear_no_evil :hear_no_ evil:, speak_no_evil 🙊 are NOT in Emoji cheat sheet.
These are listed as :see_no_evil_monkey:, :hear_no_evil_monkey: and :speak_no_evil_monkey: in Emoji cheat sheet, and I have confirmed that these shortcodes will not rendered correctly in Congo.
Similar examples were found in many flag glyphs like :flag_japan: during the translation process.

This is NOT the fault of @jpanther and us.
Because Hugo's official documentation has a similar description.
I also found a related Issue in the Hugo repository.
See. gohugoio/hugo#6740
However, at this time, the opposite is happening to the Issue, GitHub format shortcode is working correctly instead of the Emojipedia format.
See. https://emojipedia.org/hear-no-evil-monkey#technical

In short, this is a Hugo bug, not a Congo bug, but at least we should avoid directing users from Congo's documentation to the Emoji cheat sheet because it is confusing to Congo users.

Theme version

v2.6.1

Hugo version

hugo v0.115.4+extended darwin/arm64

Which browser rendering engines are you seeing the problem on?

Chromium (Google Chrome, Microsoft Edge, Brave, Vivaldi, Opera, etc.), WebKit (Safari)

URL to sample repository or website

https://jpanther.github.io/congo/samples/emoji/

Hugo output or build error messages

No build error.
@shin-sforzando shin-sforzando added the bug Something isn't working label Jul 25, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any recent activity.
If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open.
This issue will automatically close in 14 days if no further activity occurs.

@github-actions github-actions bot added the stale This issue or pull request has not had any recent activity label Aug 25, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
@shin-sforzando
Copy link
Contributor Author

Don't close it until it is fixed.
It should be a minor bug that only requires a small modification to the document.

And I don't think the actions that automatically label and close issues are working effectively for this project.

@jpanther
Copy link
Owner

jpanther commented Sep 9, 2023

@shin-sforzando Apologies, I agree that the stale actions are a bit too aggressive. When I first set them up it was to keep me focussed on getting items dealt with, but I've since had a lot of changes in my personal life that have caused me to have less time available and so it's no longer an effective system. I've made a change to the stale workflow so that it now only marks stale after 120 days (it was previously 30) and so hopefully this helps to work around this problem.

As for this issue, I'll reopen it as I agree with your comments.

@jpanther jpanther reopened this Sep 9, 2023
@jpanther jpanther removed the stale This issue or pull request has not had any recent activity label Sep 9, 2023
@jpanther jpanther added the documentation Improvements or additions to documentation label Sep 10, 2023
@shin-sforzando
Copy link
Contributor Author

@jpanther I know very well that you are so busy.
If there is anything I can do to help, please reach out to me anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants