-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Return truncated rows from encoded_text instead of raising an error #114
Comments
The sounds like a useful change. I might implement it by adding a new |
Thanks! That would be most helpful indeed! |
@natekspencer #115 implements the |
That looks great to me @jparise! |
@natekspencer Great! I just merged it to |
@jparise it worked exactly like I expected it to for my use case! Thanks again! |
Right now, when
encode_text
is called with data that results in a number of rows greater than 6, a ValueError is raised. It would be nice if, instead, this could log a warning, and then return only the first 6 rows. This would be useful for truncating long song names while also trying to append a header or footer without introducing more complex logic.The text was updated successfully, but these errors were encountered: