Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assignment to list / map fields from any implementation of sequence / mapping protocols #66

Open
kamalmarhubi opened this issue May 27, 2015 · 1 comment

Comments

@kamalmarhubi
Copy link
Contributor

Check against the Sequence and Mapping ABCs from collections.

From @jparyani on a mailing list discussion:

add them to the bottom of the if/else type checking chain since isinstance takes close to 100x as long as the current type checking. Take a look at https://github.com/jparyani/pycapnp/blob/a5bf532d53db37414d5e6b25f139ef237a854cc1/capnp/lib/capnp.pyx#L686 to see the logic for this. While you're at it, we should add the same for dict->collections.Mapping.

@kamalmarhubi
Copy link
Contributor Author

I don't seem to be able to assign the issue to myself, but I'm doing this.

kamalmarhubi added a commit to kamalmarhubi/pycapnp that referenced this issue Jun 2, 2015
kamalmarhubi added a commit to kamalmarhubi/pycapnp that referenced this issue Jun 2, 2015
@haata haata added this to To do in pycapnp v2.x.x Jan 10, 2020
@haata haata added this to To do in pycapnp v2.1.0 via automation Nov 20, 2020
@haata haata removed this from To do in pycapnp v2.x.x Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant