Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between .drw XML schema and actual DrawFBP output #15

Closed
ERnsTL opened this issue Aug 9, 2018 · 4 comments
Closed

Discrepancies between .drw XML schema and actual DrawFBP output #15

ERnsTL opened this issue Aug 9, 2018 · 4 comments

Comments

@ERnsTL
Copy link

ERnsTL commented Aug 9, 2018

Greetings, there are some observed differences / discrepancies between what is defined in the XML schema file for .drw files and what is actually output by DrawFBP.

Observations so far:

  • block > issubnet is not defined in the XML schema, but present in the actual output
  • block > subnetports > subnetport is not defined in the XML schema, but present in the actual output
@jpaulm
Copy link
Owner

jpaulm commented Aug 14, 2018

XML schema has been expanded to include subnetport[s] - has already been promoted to DrawFBP lib web pages...

@ERnsTL could you test this? One of the validation products doesn't seem to like the drawfbp_file document type... Thanks in advance!

@ERnsTL
Copy link
Author

ERnsTL commented Aug 16, 2018

Thanks for adding the subnetports

The document and XSD validates:

I downloaded the .xsd XML schema and ran xmllint:

$ xmllint --schema drawfbp_file.xsd filelinefiltercount.drw --noout

filelinefiltercount.drw validates

Also tried the W3C online XML and XSD validator. Pasted an example .drw file and the .xsd files. Result:

  • .drw is well-formed (I added the tag manually; didn't try the new DrawFBP version yet);
  • the updated XSD schema as is right now in Github also validates and
  • the .drw file validates against the schema :-)

But the schema reference URL seems to be wrong. It is xsi:noNamespaceSchemaLocation="https://github.com/jpaulm/drawfbp/blob/master/lib/drawfbp_file.xsd" but this URL leads to an HMTL page with the .xsd nicely formatted for human reading. The URL should be https://raw.githubusercontent.com/jpaulm/drawfbp/master/lib/drawfbp_file.xsd - this points to the received the plain/raw .xsd file itself.

This is the same URL you get when you click on "View raw" from this page.

Apart from that the new schema version looks OK.

I can check .drw files generated with the new DrawFBP version when it is on Maven.

@ERnsTL
Copy link
Author

ERnsTL commented Aug 16, 2018

Just ran an updated diagram saved using v2.14.2 with subnetports through the W3C's XML validator again; the XML is well-formed and conforms to the XSD schema.

Should be fine now.

@jpaulm
Copy link
Owner

jpaulm commented Aug 18, 2018

Closed with v2.14.2

@jpaulm jpaulm closed this as completed Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants