-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lockup on code generation if port name is missing #60
Comments
Thanks Michael, that's a big help - hope to deliver a new version within the next week... Cheers |
Fixed as of v2.22.4 - at least, doesn't lock! Question for @bergm : should users be forced to enter a port name? Thanks |
As of your philosophy of not forcing much at a certain point in time, I would say no. At any point a user might not know the port name (yet). IMO, It would be best (from a useability point of view) to mark a missing port name in an obvious way, so the user has a hard time missing it. Or maybe alert him when he wants to generate code. A further reason for not enforcing it, is that you used it to create flows for all kinds of illustration purposes. And maybe one just doesn't want to show a port name because it's unnecessary detail. All in all I kind of learned to appreciate your stance of not forcibly coupling code and diagram elements in time and space, like most other tools do. |
Important point! I am now just generating a message if you decide to generate code... If the port name is omitted, I am now also putting a question mark in the port number in the generated code... Thanks, as always! |
When generating code for a flow when a port name is missing, drawFBP freezes.
Just create two processes, connect them and remove one port name. When creating the code, the window freezes and one has to kill the process.
The text was updated successfully, but these errors were encountered: