Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Giveaway Does Not Exist" #15

Closed
twwright opened this issue Jan 21, 2019 · 6 comments
Closed

"Giveaway Does Not Exist" #15

twwright opened this issue Jan 21, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@twwright
Copy link

twwright commented Jan 21, 2019

After finishing the first page, it no longer "finds" giveaways. Error happens even after exiting and restarting from any page (e.g. --start=2)
image

After restarting the Node.js command prompt and starting the package from scratch, it works again. Not sure if the issue is with the package or with a possible Amazon rate-limiter?
image

Edit: Seems to happen after every page switch?

@jpchip
Copy link
Owner

jpchip commented Jan 23, 2019

Interesting, I wonder if they've changed their css to prevent things like this tool from working? I'll take a look!

@jpchip jpchip self-assigned this Jan 23, 2019
@jpchip jpchip added the bug Something isn't working label Jan 23, 2019
@jpchip
Copy link
Owner

jpchip commented Jan 23, 2019

I just gave this a try and it keeps chugging along for me, through multiple pages. Maybe some more steps to reproduce? Are you using the cli or npm start?

@Mitchvassar
Copy link

error

Same issue, but starting from page 1. I tried both cloning + npm start and just using npm install + CLI. It does go to the page, but it seems to get stuck there.

@jpchip
Copy link
Owner

jpchip commented Feb 4, 2019

oh geez, looks like they totally refactored their giveaway site, class names are completely different now. :(

Going to be a big effort to update things. If you want to chip in on helping feel free, otherwise will have to wait till I have a bit more free time. Sorry y'all.

@birdlavv
Copy link
Contributor

birdlavv commented Feb 5, 2019

I've created a pull request (hopefully I did it right). I updated the selectors & xpath. Modifications work on my end with the most recent release. Link to PR: #17

@jpchip
Copy link
Owner

jpchip commented Feb 5, 2019

Thank you @birdlavv! I published your updates to npm, and added you to the package contributors list.

Also thanks @Mitchvassar and @twwright for bringing the issue to my attention.

@jpchip jpchip closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants