Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config File #40

Closed
jpchip opened this issue Mar 30, 2019 · 2 comments · Fixed by #64
Closed

Config File #40

jpchip opened this issue Mar 30, 2019 · 2 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jpchip
Copy link
Owner

jpchip commented Mar 30, 2019

There are starting to be a lot of options, which are hard to enter via cli, and annoying to maintain as both cli and .env file options. Refactor app to run off a json config file instead, which would have all available options inside it.

  1. add an init command, like gg init which would generate the config file (ie. ggrc.json)
  2. Running gg without config file will ask you to run gg init first
  3. Drop support for env variables and force everything to be in the single config file. Leave --page support.

Can do this all using the yargs library that's already part of the code base. Would be extra cool though if gg init prompted you for credentials and stuff, using Inquirer.js.

This would be a HUGE breaking change and would have to be a major release.

Not sure if I'll have the time to go through with this, but wanted to write it down while I was thinking about it.

@jpchip jpchip added the enhancement New feature or request label Mar 30, 2019
@jpchip jpchip added this to the V3 milestone Mar 31, 2019
@jpchip jpchip self-assigned this Apr 10, 2019
@jpchip jpchip added this to In progress in V3 and beyond priority list Apr 18, 2019
@jpchip jpchip moved this from In progress to Done in V3 and beyond priority list Apr 18, 2019
@famewolf
Copy link

Does your gg init import information from the .env to populate the config file? I could easily write a shell script to convert a .env into a config file since all the information is already there but that wouldn't work for the windows users. I ask because I just built my config file manually copying info from my .env so don't know how it works.

@jpchip
Copy link
Owner Author

jpchip commented Apr 18, 2019

Nope, it does not. I thought about it, but it seemed like way too much effort for me, so I put that effort on the user instead. :p But running gg init would have walked you step by step through entering the values for the config file. What you did wasn't much harder though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants