Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support install files in lib64 #27

Closed
ycollet opened this issue Sep 22, 2018 · 6 comments
Closed

Support install files in lib64 #27

ycollet opened this issue Sep 22, 2018 · 6 comments

Comments

@ycollet
Copy link

ycollet commented Sep 22, 2018

Hello,

Under fedora, lib files are installed in lib64 directory.
This behavior should be managed be the CMakeLists.txt file.

Best regards,

YC

@jpcima
Copy link
Owner

jpcima commented Sep 22, 2018

Hopefully I've handled it correctly in 726cd90. I've not made such a thing previously, and don't have a Fedora Linux setup at immediate disposal.
(but Fedora is doing a fine work at powering my Windows builds at the present time 😉 )

@ycollet
Copy link
Author

ycollet commented Sep 22, 2018

Thanks for the commit, I will test this ASAP.

@jpcima
Copy link
Owner

jpcima commented Sep 22, 2018

You're welcome. Let me know if you make some (s)rpm available so I can mention Fedora in the README.

@ycollet
Copy link
Author

ycollet commented Sep 22, 2018

Work in progress :)

@ycollet
Copy link
Author

ycollet commented Sep 22, 2018

The build is ready.
The Copr repo: https://copr.fedorainfracloud.org/coprs/ycollet/linuxmao/
The spec file can be found here: https://github.com/ycollet/fedora-spec

@jpcima
Copy link
Owner

jpcima commented Sep 22, 2018

Good 👍
Just for some commentary and clarification about the work done, let me have a few remarks.

  • not all of ADLplug is Boost licensed. I know I must change the license file at the root to make this point clear. ADLplug is made partially of libraries governed under several GPL-compatible licenses.
    On Linux MAO, I have written a list of these licenses. If the package can allow a specification of multiple licenses, it would be better that way. BSL leaves it to be believed that ADLplug is a liberally-licensed program in entirety, but it's not.

  • I hope to make beta 2 happen in a very short term. I have fixed the project dependencies so curl headers will not be required anymore.

  • I notice the package summary is wrong as it describes the lmms software.

  • You can have the OPNplug build in a nearly identical way, it's a name change and a flag to cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants