Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] MiniMOTD no fake player edition #104

Closed
itsdinkd opened this issue Jun 8, 2022 · 5 comments
Closed

[Feature Request] MiniMOTD no fake player edition #104

itsdinkd opened this issue Jun 8, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@itsdinkd
Copy link

itsdinkd commented Jun 8, 2022

Is your feature request related to a problem? Please describe.
Currently there is a huge problem with kyori adventure and industrial revolution and Create on how these mods fake player apis conflict with kyori to the point where the only solution is either removing all mods that use kyori, or having fabric api develop a fake player api and these mods implement that once done (which can take a long time).

I do not want to remove your mod from my packs official servers.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Release a version of MiniMOTD without the fake player feature so that it doesn't use kyori adventure platform

Describe alternatives you've considered
Listed in first description.

Additional Content
This request is for 1.18.2, and would not only be for me, but for anyone else using your mod along with create or industrial revolution

@itsdinkd itsdinkd added the enhancement New feature or request label Jun 8, 2022
@jpenilla
Copy link
Owner

jpenilla commented Jun 8, 2022

I think you have a misunderstanding of the fake player api mentioned at KyoriPowered/adventure-platform-fabric#15, it has nothing to do with the "fake player count" MiniMOTD feature. If there is a conflict it's due to other mods implementing fake players improperly, but this is a adventure-platform-fabric thing, not a MiniMOTD issue.

@jpenilla jpenilla closed this as completed Jun 8, 2022
@HaXrBOT
Copy link

HaXrBOT commented Jul 4, 2022

Even though this issue is to do with the Create mod's Fake Player implementation. A version of this mod that doesn't touch those aspects of the game at all would be ideal to prevent this issue until a proper solution is built into the Fabric API itself. But of cause, if the entire mod has been built around adventure-platform-fabric then i guess there isn't much you can do.

@itsdinkd
Copy link
Author

itsdinkd commented Jul 4, 2022

Even though this issue is to do with the Create mod's Fake Player implementation. A version of this mod that doesn't touch those aspects of the game at all would be ideal to prevent this issue until a proper solution is built into the Fabric API itself. But of cause, if the entire mod has been built around adventure-platform-fabric then i guess there isn't much you can do.

Tired of mods blaming other mods and then that mod dev blames the other mod. Someone needs to do something. All I know is create and increase both crash when kyori adventure platform is used and kyori said they cannot do anything, and the other devs of those two mods cannot do anything.

To the dev: The only option left is removing the mods that use kyori platform. So if you can release a version without it that would be beneficial otherwise I see a feature where a lot of people stop using your mods as Create and Indrev are going to be preferred over them.

@HaXrBOT
Copy link

HaXrBOT commented Jul 4, 2022

Tired of mods blaming other mods and then that mod dev blames the other mod. Someone needs to do something. All I know is create and increase both crash when kyori adventure platform is used and kyori said they cannot do anything, and the other devs of those two mods cannot do anything.

To the dev: The only option left is removing the mods that use kyori platform. So if you can release a version without it that would be beneficial otherwise I see a feature where a lot of people stop using your mods as Create and Indrev are going to be preferred over them.

I completely agree with this sentiment. I was referring to what i was told in another thread related to this issue. It is really sad as i really wanted to use both mods together. jpenilla/better-fabric-console#11

@jpenilla
Copy link
Owner

jpenilla commented Jul 4, 2022

This is a create issue and is perfectly fixable from their side, as can be seen by carpet mod previously having the same issue and it now being fixed: gnembon/fabric-carpet#1235

Repository owner locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants