Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Support for rustc nightly 2014-06-29 #9

Merged
merged 1 commit into from Jul 4, 2014

Conversation

samyatchmenoff
Copy link
Collaborator

  • Changed * to *const
  • Changed enum repr to i32 to fix type mismatch errors
  • Also an unrelated change that fixes Source::unqueue_buffer and Source::unqueue_buffers so they handle errors and return results instead of filling buffers

@samyatchmenoff
Copy link
Collaborator Author

Actually I'm having seconds thoughts about trying to handle errors like that. I think the library should either check and report errors universally or shouldn't do it at all. Opinions?

@samyatchmenoff
Copy link
Collaborator Author

I've gone ahead and removed the error handling until a deliberate decision is made about it.

@brendanzab
Copy link
Collaborator

Ack, sorry for the late reply. Yeah, this is awesome! Thanks for your great work! As my last request, could you squash the last three commits into one?

@samyatchmenoff
Copy link
Collaborator Author

I assume you mean all the commits since the last pull request which is actually 5 commits. They are all squashed now.

I'll keep the pull requests cleaner from now on.

@brendanzab
Copy link
Collaborator

👍 - sorry for all the bother, thanks so much for your contribution! ^_^

brendanzab added a commit that referenced this pull request Jul 4, 2014
Support for rustc nightly 2014-06-29
@brendanzab brendanzab merged commit f823eea into jpernst:master Jul 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants