looking for NULL fields uses equal sign instead of IS

[greut]

I realised that PHP AR wasn't handling WHERE correctly while looking for NULL fields doing = instead of IS.

And MySQL doesn't like that, Problems with NULL Values:
“To look for NULL values, you must use the IS NULL test.”

Find here a little patch, because I'm too lazy to branch and send a pull request that (you'll cherry pick anyway).

Cheers,

diff --git a/lib/Expressions.php b/lib/Expressions.php
index ee7509c..0c1d076 100644
--- a/lib/Expressions.php
+++ b/lib/Expressions.php
@@ -132,6 +132,8 @@ class Expressions

            if (is_array($value))
                $sql .= "$g$name IN(?)";
+           else if (is_null($value))
+               $sql .= "$g$name IS ?";
            else
                $sql .= "$g$name=?";

diff --git a/test/SQLBuilderTest.php b/test/SQLBuilderTest.php
index 29ea734..4ce5e7a 100644
--- a/test/SQLBuilderTest.php
+++ b/test/SQLBuilderTest.php
@@ -67,6 +67,13 @@ class SQLBuilderTest extends DatabaseTest
        $this->assert_equals(array(1,'Tito','Mexican'),$this->sql->get_where_values());
    }

+   public function test_where_with_hash_and_null()
+   {
+       $this->sql->where(array('id' => 1, 'name' => null));
+       $this->assert_sql_has("SELECT * FROM authors WHERE id=? AND name IS ?",(string)$this->sql);
+       $this->assert_equals(array(1, null),$this->sql->get_where_values());
+   }
+
    public function test_where_with_null()
    {
        $this->sql->where(null);

[greut]

the commit: greut@7ef3060

[jpfuentes2]

Thanks:

490f119