Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add]ログイン画面のUI #64

Merged
merged 2 commits into from
Oct 30, 2021
Merged

[add]ログイン画面のUI #64

merged 2 commits into from
Oct 30, 2021

Conversation

putcho01
Copy link
Member

@putcho01 putcho01 commented Oct 29, 2021

close #26

やったこと

ログイン画面のUI作成

スクリーンショット

スクリーンショット 2021-10-29 23 37 21

@github-actions
Copy link

Success to deploy preview URL!

https://voice-tag-24nxlqgit-japascript-googlegroups.vercel.app

Copy link
Contributor

@yuta-ike yuta-ike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

時間があればここの画像の部分がウィンドウ比率によって横長になったり縦長になったりしないようにしてもらえると良きです!

Comment on lines +8 to +11
import dynamic from "next/dynamic"
const Image = dynamic(() => import("next/image"), {
ssr: false,
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imageをdynamic importじゃなくても動く気がしたんですけどどうでしょうか...👀

@yuta-ike
Copy link
Contributor

yuta-ike commented Oct 29, 2021

いくつかコメントしましたがApproveです〜〜
余裕あれば修正、なければマージって感じでお願いしますmmmmm

Copy link
Contributor

@yuta-ike yuta-ike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

CI通ればマージで!

@github-actions
Copy link

Success to deploy preview URL!

https://voice-tag-qg1thpcdn-japascript-googlegroups.vercel.app

@yuta-ike yuta-ike merged commit 89d9f16 into main Oct 30, 2021
@yuta-ike yuta-ike deleted the feature/login-ui branch October 30, 2021 01:39
@yuta-ike yuta-ike linked an issue Oct 30, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI実装(トップページ)
2 participants