Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the OML grammar to allow a digit-leading character for an ID. #299

Closed
NicolasRouquette opened this issue Jul 31, 2018 · 1 comment
Closed

Comments

@NicolasRouquette
Copy link
Member

Without this fix, there are problems constructing OML models with names like this:

OMLConverterFromOntologySyntax (Error while saving to OML): Error while converting value '2ASwitches10_zHdNhIFpEeiNqNyH9cEJTQ' for grammar rule 'ID' to string via ValueConverter.
Semantic Object: Extent.modules[0]->TerminologyGraph.boxStatements[0]->Concept'2ASwitches10_zHdNhIFpEeiNqNyH9cEJTQ'
URI: file:/opt/local/imce/users/nfr/github.caesar/europa.integration/target/conv.text/libraries.resources/europa.jpl.nasa.gov/efse/libraries/AssemblyTypes.oml
EStructuralFeature: omlt::Term.name
java.lang.RuntimeException: Error while converting value '2ASwitches10_zHdNhIFpEeiNqNyH9cEJTQ' for grammar rule 'ID' to string via ValueConverter.
Semantic Object: Extent.modules[0]->TerminologyGraph.boxStatements[0]->Concept'2ASwitches10_zHdNhIFpEeiNqNyH9cEJTQ'
URI: file:/opt/local/imce/users/nfr/github.caesar/europa.integration/target/conv.text/libraries.resources/europa.jpl.nasa.gov/efse/libraries/AssemblyTypes.oml
EStructuralFeature: omlt::Term.name

	at org.eclipse.xtext.serializer.diagnostic.ISerializationDiagnostic$ExceptionThrowingAcceptor.accept(ISerializationDiagnostic.java:129)
	at org.eclipse.xtext.serializer.tokens.ValueSerializer.serializeAssignedValue(ValueSerializer.java:82)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.getToken(SequenceFeeder.java:489)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.accept(SequenceFeeder.java:244)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.accept(BacktrackingSemanticSequencer.java:441)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.createSequence(BacktrackingSemanticSequencer.java:501)
	at gov.nasa.jpl.imce.oml.dsl.serializer.OMLSemanticSequencer.sequence_Concept(OMLSemanticSequencer.java:660)
	at gov.nasa.jpl.imce.oml.dsl.serializer.OMLSemanticSequencer.sequence(OMLSemanticSequencer.java:259)
	at org.eclipse.xtext.serializer.sequencer.AbstractSemanticSequencer.createSequence(AbstractSemanticSequencer.java:67)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.acceptEObjectRuleCall(SequenceFeeder.java:325)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.acceptRuleCall(SequenceFeeder.java:352)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.accept(SequenceFeeder.java:263)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.accept(BacktrackingSemanticSequencer.java:434)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.createSequence(BacktrackingSemanticSequencer.java:501)
	at gov.nasa.jpl.imce.oml.dsl.serializer.OMLSemanticSequencer.sequence_TerminologyGraph(OMLSemanticSequencer.java:1624)
	at gov.nasa.jpl.imce.oml.dsl.serializer.OMLSemanticSequencer.sequence(OMLSemanticSequencer.java:229)
	at org.eclipse.xtext.serializer.sequencer.AbstractSemanticSequencer.createSequence(AbstractSemanticSequencer.java:67)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.acceptEObjectRuleCall(SequenceFeeder.java:325)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.acceptRuleCall(SequenceFeeder.java:352)
	at org.eclipse.xtext.serializer.acceptor.SequenceFeeder.accept(SequenceFeeder.java:263)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.accept(BacktrackingSemanticSequencer.java:434)
	at org.eclipse.xtext.serializer.sequencer.BacktrackingSemanticSequencer.createSequence(BacktrackingSemanticSequencer.java:501)
	at gov.nasa.jpl.imce.oml.dsl.serializer.OMLSemanticSequencer.sequence_Extent(OMLSemanticSequencer.java:876)
	at gov.nasa.jpl.imce.oml.dsl.serializer.OMLSemanticSequencer.sequence(OMLSemanticSequencer.java:151)
	at org.eclipse.xtext.serializer.sequencer.AbstractSemanticSequencer.createSequence(AbstractSemanticSequencer.java:67)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:115)
	at org.eclipse.xtext.serializer.impl.Serializer.serializeToRegions(Serializer.java:136)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:142)
	at org.eclipse.xtext.serializer.impl.Serializer.serialize(Serializer.java:189)
	at org.eclipse.xtext.resource.XtextResource.doSave(XtextResource.java:386)
NicolasRouquette added a commit that referenced this issue Aug 1, 2018
NicolasRouquette added a commit that referenced this issue Aug 1, 2018
NicolasRouquette added a commit that referenced this issue Aug 1, 2018
@NicolasRouquette
Copy link
Member Author

Need to relax the ID format requirements to allow arbitrary characters and convert an OML ID to a well-formed fragment via character encoding.

NicolasRouquette added a commit that referenced this issue Aug 1, 2018
NicolasRouquette added a commit that referenced this issue Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant