Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GTVER #15

Closed
DanBoothDev opened this issue Nov 27, 2020 · 2 comments
Closed

Add support for GTVER #15

DanBoothDev opened this issue Nov 27, 2020 · 2 comments

Comments

@DanBoothDev
Copy link
Contributor

DanBoothDev commented Nov 27, 2020

GTVER is a very useful report for firmware/hardware versions. I added it in #14 but only implemented GL300M devices.

We might also want to add support for more items in devices.h such as:

int device_type;    /* String representation of the device type e.g. gl300m */
int ver_fw;            /* HEX firmware version MAMI for MAjor MInor */
int ver_hw            /* HEX hardware version MAMI for MAjor MInor */

This is something that I could happily undertake and submit a PR when ready.

@jpmens
Copy link
Owner

jpmens commented Nov 27, 2020

I think that's a good idea, @DanBoothDev, and we'll happily entertain your PR when you're done. Thank you.

@jpmens
Copy link
Owner

jpmens commented Nov 29, 2020

Closed via #16

@jpmens jpmens closed this as completed Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants