Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure is_hidden is properly handled #167

Closed
timkpaine opened this issue May 30, 2023 · 2 comments
Closed

Ensure is_hidden is properly handled #167

timkpaine opened this issue May 30, 2023 · 2 comments

Comments

@timkpaine
Copy link
Collaborator

https://github.com/jpmorganchase/jupyter-fs/blob/main/jupyterfs/fsmanager.py#L143 should be replaced with an actual check, else hardcoded to !=exists instead of the current ==exists.
This was referenced May 30, 2023
Closed
Merged
@timkpaine
Copy link
Collaborator Author

will fix on fork

@vidartf
Copy link
Contributor

vidartf commented Jun 6, 2023

FYI: There should also be a good fix in #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vidartf @timkpaine