Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a namespace to package names #76

Closed
threepointone opened this issue Sep 3, 2020 · 4 comments
Closed

add a namespace to package names #76

threepointone opened this issue Sep 3, 2020 · 4 comments
Labels
enhancement New feature or request low priority

Comments

@threepointone
Copy link
Contributor

  • yarn create modular-react-app xyz should create a repo with package.json's name as '@xyz/workspace' (or '@xyz/root')
  • packages, including the app should be prefixed with '@xyz' (except for the default 'shared' package, maybe?)
@threepointone threepointone added the enhancement New feature or request label Sep 6, 2020
@sebinsua
Copy link
Contributor

It should be pointed out that this will make #77 visible, since there would then be a distinction between a package name which has a scope prefix and a directory name which cannot.

@NMinhNguyen
Copy link
Contributor

directory name which cannot.

I think you can have a folder e.g. @babel which then contains folders like core inside. At least that's what my node_modules looks like.

@sebinsua
Copy link
Contributor

^ Yes, but that'd then be a change away from packages/*!

@threepointone
Copy link
Contributor Author

We're not going to enforce scoping of package names, in practice it's never a given (the modular repo being a promise example). Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

3 participants