ResizeObserver is not defined in testing

[efriandika]

Package name(s)

Core v1.4.0 (@salt-ds/core)

Description

I just added SaltProvider to our team react app,
Then I get this below error when running our unit test:

ResizeObserver is not defined
ReferenceError: ResizeObserver is not defined

Steps to reproduce

Add SaltProvider to our team react app,
Then create a unit test.

Expected behavior

There is better way to handle ResizeObserver

Operating system

• macOS
• Windows
• Linux
• iOS
• Android

Browser

• Chrome
• Safari
• Firefox
• Edge

Are you a JPMorgan Chase & Co. employee?

• I am an employee of JPMorgan Chase & Co.

[efriandika]

Currently by adding:

salt-ds/modular/setupTests.ts

Line 7 in c3b945f

class ResizeObserver {

can solve this.

However, It would be great if there is a better way to handle this out of the box

[origami-z]

This is a limitation of your unit test framework (assuming jsdom). Nothing really can be done from Salt side.

[efriandika]

Thanks for the reply @origami-z ,
I know it's limitation of JSdom. If you think it really can't be done from salt side. I suggest that it worth to mention in documentation.

[joshwooding]

Hi @efriandika, sorry for the slow reply. As @origami-z said, this is a limitation of JSDom and quite a common one. I would either recommend using a test framework which has support for browser features or poly-filling/mocking it.

I think you'll run into this with almost any component library so I'm not sure how critical it is to document, as other component libraries seem not to document it.

I will close this for now, and if it has a lot of support, we can revisit this decision.

Thanks