Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlaid Drawer component design #3306

Closed
bhoppers2008 opened this issue Apr 26, 2024 · 8 comments
Closed

Inlaid Drawer component design #3306

bhoppers2008 opened this issue Apr 26, 2024 · 8 comments

Comments

@bhoppers2008
Copy link

Provide designs for Inlaid Drawer using existing layout (parent-child, border layouts) and UI components, and Salt --spacing tokens for margins.

Document as examples.

Designs provide the basis for Pepper inlaid drawer patterns.

@origami-z origami-z assigned navkaur76 and unassigned ivan-calderon Jun 7, 2024
@origami-z origami-z changed the title Inlaid Drawer design Inlaid Drawer design and publish to site Jun 7, 2024
@origami-z
Copy link
Contributor

Waiting for a11y direction

@mark-tate
Copy link
Contributor

Zazu Goal: M(5)

  • waiting for a11y feedback from Jared

Outstanding Decision

  • Should Inlaid drawer be a component ? (create issue for decision, pattern or component)

@navkaur76
Copy link
Contributor

Kick off notes:

Two separate concerns:

Implement Inlaid Drawer somewhere in code as component.

Nav to do docs + specs + figma for component – Design work to be done by EOS (Zazu).
i. To confirm what will be in component vs example (Josh)
ii. Asmita to identify definitive ‘drawer’ requirements that Pepper need from Salt.
Build > Pepper dev to build (Thushara/Vineet) in Americano.
i. T/V to confirm with Adrian whether unopinionated Inlaid Drawer is sufficient from Pepper, specifically:

  • Do Pepper actually need inlaid behaviour?
  • Pepper happy to build header/footer/main regions into Salt Drawer as Pepper component/pattern?

Asmita to follow up with Anh/Adrian/JJ Pepper implementation of Drawer (Salt to update as necessary).

Modal behaviour on Overlay Drawer (ability to interact with app underneath) is a separate issues.
Ben/Josh to align on follow-up with Jared.

@navkaur76 navkaur76 changed the title Inlaid Drawer design and publish to site Inlaid Drawer component Jun 27, 2024
@origami-z origami-z changed the title Inlaid Drawer component Inlaid Drawer component design Jul 5, 2024
@navkaur76
Copy link
Contributor

  • Nav working on site docs, likely some overlap into Americano for reviews + final decisions on how we want to handle sizing (i.e. follow drawer, or provide S/M/L set sizes).
  • Characteristics complete, enough available for Pepper devs to make a start on build

@mark-tate
Copy link
Contributor

Goal: ready for Dev by EOS

@navkaur76
Copy link
Contributor

Figma assets merged (Salt 1 Light/Dark, Salt Next + figma guide)

@navkaur76
Copy link
Contributor

Carryover to address ADA spec w/ Jake

@navkaur76
Copy link
Contributor

Outstanding ADA questions addressed with Jake in figma spec. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

No branches or pull requests

6 participants